Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] no-jira: Collect bootstrap logs when control plane provisioning fails #9308

Merged
merged 4 commits into from
Dec 18, 2024
Merged

[release-4.17] no-jira: Collect bootstrap logs when control plane provisioning fails #9308

merged 4 commits into from
Dec 18, 2024
+29 −17

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #9123

/assign patrickdillon

@patrickdillon
Add ControlPlaneCreation error constant
8a8890b 
Adds a ControlPlaneCreation error that is returned on all
non-baremetal platforms when control plane machines fail
to provision so that we can parse the error and gather
logs when appropriate.
@patrickdillon
Refactor log collection/analysis into a function
ed95a45 
Creates a function for gathering and analyzing bootstrap logs so that
it can be reused.
@patrickdillon
Gather bootstrap logs on provisioning failure
9c75fca 
Gathers and analyzes bootstrap logs on provisioning failure. This
will help gather serial console & other logs during provisioning
failures. Prior to this change. gathering only happened if infra
provisioning succeeded but we can gather more logs to help us
understand provisioning failures.
@patrickdillon
Support ControlPlaneCreationError on baremetal
326ed9a 
Wraps control plane provisioning errors on baremetal IPI with the
ControlPlaneCreationError so that gather bootstrap will run
automatically in that case.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2024
Merged
@patrickdillon
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 11, 2024
@openshift-ci openshift-ci bot requested review from elfosardo and sadasu December 11, 2024 17:03
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Dec 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gpei
Copy link
Contributor

gpei commented Dec 12, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 12, 2024
@patrickdillon patrickdillon added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6e3f5e3 into openshift:release-4.17 Dec 18, 2024
22 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202412180637.p0.g6e3f5e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202412180637.p0.g6e3f5e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202412180637.p0.g6e3f5e3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202412180637.p0.g6e3f5e3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfosardo elfosardo Awaiting requested review from elfosardo

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@patrickdillon patrickdillon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @patrickdillon @gpei @openshift-bot